Disable debug draw modes in the 3D editor according to current rendering method #93673
+135
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
3d-editor-debug-draw-modes-mark-unsupported
branch
from
a4824bb
to
31663a1
Compare
Mickeon
reviewed
Jun 27, 2024
Calinou
force-pushed
the
3d-editor-debug-draw-modes-mark-unsupported
branch
from
31663a1
to
0746718
Compare
…ing method - Add tooltips to some debug draw modes, including when it's unsupported due to the current rendering method in use. - Improve documentation related to debug draw modes.
Calinou
force-pushed
the
3d-editor-debug-draw-modes-mark-unsupported
branch
from
0746718
to
fa46a3d
Compare
Mickeon
approved these changes
Jul 5, 2024
RadiantUwU
approved these changes
Jul 6, 2024
| disabled_tooltip = TTR("This debug draw mode is not supported when using the Compatibility rendering method."); | ||
| break; | ||
| case SupportedRenderingMethods::FORWARD_PLUS: | ||
| disabled = OS::get_singleton()->get_current_rendering_method() == "gl_compatibility" || OS::get_singleton()->get_current_rendering_method() == "mobile"; |
There was a problem hiding this comment.
Suggested change
| disabled = OS::get_singleton()->get_current_rendering_method() == "gl_compatibility" || OS::get_singleton()->get_current_rendering_method() == "mobile"; | |
| disabled = OS::get_singleton()->get_current_rendering_method() != "forward_plus"; |
There was a problem hiding this comment.
While your suggestion currently does the same thing in practice, it's less semantically correct. It may matter in the future if we have a Cinematic rendering method (as mentioned in this gist), as this rendering method would likely support all debug draw modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Mobile
Compatibility